-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modifiers not being set properly in EventConfig for data (backport of #38622, 12_3_X) #38678
Modifiers not being set properly in EventConfig for data (backport of #38622, 12_3_X) #38678
Conversation
…ess.__init__`. Refer to cms-sw#38622 (comment) for more details.
A new Pull Request was created by @seungjin-yang (Seungjin Yang) for CMSSW_12_3_X. It involves the following packages:
@perrotta, @rappoccio, @cmsbuild, @qliphy, @fabiocos, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8e412f/26125/summary.html Comparison SummarySummary:
|
backport of #38622 |
+1 |
This pull request is fully signed and it will be integrated in one of the next CMSSW_12_3_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_5_X is complete. This pull request will be automatically merged. |
@perrotta can you let me know when this fix will be applied to T0? |
One of the item to be discussed at today's ORP meeting (https://indico.cern.ch/event/1179450/) is exactly whether and when a new 12_3_X release will be needed, and by whom (i.e. T0). Even if we decide to build a new release, it will last just a few days, since the plan is to move T0 to 12_4 soon. |
@perrotta Many thanks! |
PR description:
This PR is a backport of #38622. This PR intoduces the lazy import of
Configuration.EventContent.EventContent_cff
to avoid callingModifier.toModify
beforeProcess.__init__
. The issue is well described in #38622.PR validation:
Same as #38622.
If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:
This PR is a backport of #38622. This fix should be applied to releases for Run2022.
@jshlee @watson-ij